Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use case document #482

Merged
merged 16 commits into from
Jul 6, 2020
Merged

Add use case document #482

merged 16 commits into from
Jul 6, 2020

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Jun 16, 2020

Author review required?

Description:

This PR create the use case document to describe the general use case of Vald.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@kevindiu
Copy link
Contributor Author

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: documentation/usecase

docs/usecase/usage-example.md Outdated Show resolved Hide resolved
docs/usecase/usage-example.md Outdated Show resolved Hide resolved
docs/usecase/usage-example.md Outdated Show resolved Hide resolved
docs/usecase/usage-example.md Outdated Show resolved Hide resolved
docs/usecase/usage-example.md Outdated Show resolved Hide resolved
docs/usecase/usage-example.md Outdated Show resolved Hide resolved
@kevindiu
Copy link
Contributor Author

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: documentation/usecase

@kevindiu
Copy link
Contributor Author

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: documentation/usecase

hlts2
hlts2 previously approved these changes Jun 24, 2020
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu kevindiu changed the title [draft] add use case document Add use case document Jun 24, 2020
@vankichi
Copy link
Contributor

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: documentation/usecase

@kevindiu kevindiu requested a review from vankichi June 24, 2020 08:41
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hlts2
hlts2 previously approved these changes Jul 2, 2020
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vankichi
vankichi previously approved these changes Jul 6, 2020
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

vankichi commented Jul 6, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[REBASE] Rebase triggered by vankichi for branch: documentation/usecase

@vdaas-ci vdaas-ci dismissed stale reviews from vankichi and hlts2 via c1a73f4 July 6, 2020 09:42
@github-actions github-actions bot added size/M and removed size/M labels Jul 6, 2020
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 38995d0 into master Jul 6, 2020
@vankichi vankichi deleted the documentation/usecase branch July 6, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants